fitsinto: rework fitsinto to actually do subtyping #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunNova
force-pushed
the
lunnova/fitsinto-testcases
branch
from
9d58277 to
19a0da8
Compare
LunNova
changed the title
LunNova
force-pushed
the
lunnova/fitsinto-testcases
branch
from
194cccb to
2b618a2
Compare
test-fitsinto: more star cases test-fitsinto: quantity cases test-fitsinto: more cases for basic types
LunNova
force-pushed
the
lunnova/fitsinto-testcases
branch
from
2b618a2 to
f128a3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still broken for value.tuple_type but is an improvement over the completely wrong approach in my earlier commit which allowed values that aren't types.
May require yet another different approach to properly handle tuple types, not yet known.